Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant call to Reflector#getClassMethods() #2335

Merged
merged 3 commits into from
Sep 7, 2021
Merged

Remove redundant call to Reflector#getClassMethods() #2335

merged 3 commits into from
Sep 7, 2021

Conversation

mbond-cloud
Copy link

Add an attribute 'allMethods' to cache all methods,reduce repetitive operations

harawata
harawata requested changes Sep 3, 2021
View reviewed changes
Copy link
Member

@harawata harawata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

The basic idea looks OK, but I have a few suggestions.
Please see the comments.

src/main/java/org/apache/ibatis/reflection/Reflector.java Outdated Show resolved Hide resolved
src/main/java/org/apache/ibatis/reflection/Reflector.java Outdated Show resolved Hide resolved
mbond-cloud and others added 2 commits September 6, 2021 09:49
@mbond-cloud
Modify constructor ,add local variable 'allMethods' (Method[]),change…
e2d32a9 
… method 'addGetMethods' and 'addSetMethods' input parameter,from Class to Method[]
@harawata
Cosmetic changes
bd26999
@coveralls
Copy link

Coverage Status

Coverage increased (+0.008%) to 87.256% when pulling bd26999 on mbond-cloud:mbond-mybatis into 5e89813 on mybatis:master.

@harawata harawata changed the title Add an attribute 'allMethods' to cache all methods,reduce repetitive … Remove redundant call to Reflector#getClassMethods() Sep 7, 2021
@harawata harawata merged commit 47c72ae into mybatis:master Sep 7, 2021
@harawata harawata added the polishing Improve a implementation code or doc without change in current behavior/content label Sep 7, 2021
@harawata harawata self-assigned this Sep 7, 2021
@harawata harawata added this to the 3.5.8 milestone Sep 7, 2021
@harawata
Copy link
Member

harawata commented Sep 7, 2021

Thank you, @mbond-cloud !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harawata harawata harawata approved these changes

Assignees

@harawata harawata

Labels
polishing Improve a implementation code or doc without change in current behavior/content
Projects
None yet
Milestone
3.5.8
Development

Successfully merging this pull request may close these issues.
3 participants
@mbond-cloud @coveralls @harawata